better error handling in worker job

Giveth · Jan 27, 2025 · 73d6cfa · 73d6cfa
1 parent 7797caa
commit 73d6cfa
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 17 deletions.
diff --git a/src/services/cronJobs/syncEstimatedClusterMatchingJob.ts b/src/services/cronJobs/syncEstimatedClusterMatchingJob.ts
@@ -66,26 +66,26 @@ export const fetchAndUpdateClusterEstimatedMatching = async () => {
     new Worker('../../workers/cocm/estimatedClusterMatchingWorker'),
   );
 
-  const activeQfRound = await findActiveQfRound();
-  if (!activeQfRound?.id) return;
+  try {
+    const activeQfRound = await findActiveQfRound();
+    if (!activeQfRound?.id) return;
 
-  const clusterMatchingDonations = await exportClusterMatchingDonationsFormat(
-    activeQfRound?.id,
-  );
-  if (!clusterMatchingDonations || clusterMatchingDonations?.length === 0)
-    return;
+    const clusterMatchingDonations = await exportClusterMatchingDonationsFormat(
+      activeQfRound?.id,
+    );
+    if (!clusterMatchingDonations || clusterMatchingDonations?.length === 0)
+      return;
 
-  const matchingDataInput = {
-    votes_data: clusterMatchingDonations,
-    strategy: defaultMatchingStrategy,
-    min_donation_threshold_amount: activeQfRound.minimumValidUsdValue,
-    matching_cap_amount:
-      activeQfRound.allocatedFundUSD * activeQfRound.maximumReward,
-    matching_amount: activeQfRound.allocatedFundUSD,
-    passport_threshold: activeQfRound.minimumPassportScore,
-  };
+    const matchingDataInput = {
+      votes_data: clusterMatchingDonations,
+      strategy: defaultMatchingStrategy,
+      min_donation_threshold_amount: activeQfRound.minimumValidUsdValue,
+      matching_cap_amount:
+        activeQfRound.allocatedFundUSD * activeQfRound.maximumReward,
+      matching_amount: activeQfRound.allocatedFundUSD,
+      passport_threshold: activeQfRound.minimumPassportScore,
+    };
 
-  try {
     // Fetch from python api cluster matching
     const matchingData =
       await matchingWorker.fetchEstimatedClusterMatching(matchingDataInput);

diff --git a/src/workers/cocm/estimatedClusterMatchingWorker.ts b/src/workers/cocm/estimatedClusterMatchingWorker.ts
@@ -15,6 +15,7 @@ export type EstimatedClusterMatchingWorker =
 const worker: EstimatedClusterMatchingWorker = {
   async fetchEstimatedClusterMatching(matchingDataInput: any) {
     logger.debug('fetchEstimatedClusterMatching() has been called');
+    try {
     const matchingData =
       await getClusterMatchingAdapter().fetchEstimatedClusterMatchings(
         matchingDataInput,
@@ -24,6 +25,13 @@ const worker: EstimatedClusterMatchingWorker = {
       String(matchingData),
     );
     return matchingData;
+    } catch (e) {
+      logger.error(
+        'fetchEstimatedClusterMatching() did not work. Error: ',
+        e
+      );
+      return;
+    }
   },
 
   async updateEstimatedClusterMatching(qfRoundId: number, matchingData: any) {