Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] Support for Personal Access Token endpoints #827

Open
wants to merge 8 commits into
base: 12.0
Choose a base branch
from
Open

[12.0] Support for Personal Access Token endpoints #827

wants to merge 8 commits into from

Conversation

fjgarlin
Copy link
Contributor

@fjgarlin fjgarlin commented Feb 24, 2025 •
edited
Loading

Recreating #797 against the latest project branch.

Closes #796

GrahamCampbell
GrahamCampbell reviewed Feb 24, 2025
View reviewed changes
src/Api/PersonalAccessTokens.php Outdated
* @var \DateTimeInterface $last_used_before return tokens used after the given time (inclusive)
* }
*
* @return mixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move all return types to be real return types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Personal Access Token endpoints
2 participants
@fjgarlin @GrahamCampbell