C#: Add experimental queries. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/addexperimentalqueries
branch
3 times, most recently
from
094d6c2 to
312aea6
Compare
pwntester
reviewed
Nov 3, 2024
| @@ -0,0 +1 @@ | |||
| experimental/Security Features/CWE-1004/CookieWithoutHttpOnly.ql | |||
There was a problem hiding this comment.
@michaelnebel do these paths need to be updated?
There was a problem hiding this comment.
Btw. what do you think about the query IDs?
There was a problem hiding this comment.
Im ok using githubsecuritylab but maybe we want to use something related to community packs, @GeekMasher any thoughts?
There was a problem hiding this comment.
I like the use of a namespace like githubsecuritylab, I think githubsecuritylab makes sense as this is the org where the community pack resides.
There was a problem hiding this comment.
Great. I have just prefixed the query IDs with githubsecuritylab. Then lets go with that.
Should we just go ahead and get the queries merged?
pwntester
previously approved these changes
Nov 4, 2024
michaelnebel
force-pushed
the
csharp/addexperimentalqueries
branch
3 times, most recently
from
f079d10 to
e6d4cc4
Compare
michaelnebel
force-pushed
the
csharp/addexperimentalqueries
branch
from
e6d4cc4 to
94cba02
Compare
pwntester
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add all C# experimental queries to the CodeQL community pack.
At least one open question:
experimentaltag. Should we keep theexperimentaltag and keep the id's as is? It is unclear as there is also a mention in the requirement doc thatDeprecate experimental queries in CodeQL repo and point to new location.Review on a commit by commit basis is recommended.