Skip to content

Add dotfiles repo integration to swiftlint #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 16, 2025
Merged

Conversation

AdonisCodes
Copy link
Contributor

@AdonisCodes AdonisCodes commented Apr 15, 2025

Reason

We have a dotfiles repo that syncs all of our configuration files across all relevant repositories. The dotfiles repo has a swiftlint file which is standardized over the entire codebase. This PR removes the .swiftlint file & modifies the swiftlint action to use the file from dotfiles repo instead.

Tech Details List

  • Installs nodejs in swiftlint action
  • Clones dotfiles repo in swiftlint action
  • Runs npm run config in swiftlint action

ISSUE-6
closes/resolves #6

Testing

Testing can be done by runnng the swiftlint action in simon/test-new-config-files in AutomaInfraCore.

@AdonisCodes AdonisCodes added the enhancement New feature or request label Apr 15, 2025
@AdonisCodes AdonisCodes linked an issue Apr 15, 2025 that may be closed by this pull request
@AdonisCodes AdonisCodes self-assigned this Apr 15, 2025
@AdonisCodes AdonisCodes marked this pull request as ready for review April 15, 2025 14:29
Copy link

@vimscientist69 vimscientist69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One thing, can you make the function limit size to 100 in swiftlint, and struct/class limit size to 500?

@AdonisCodes AdonisCodes merged commit 2dceda3 into main Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .dotfiles
2 participants