Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add qc_filter function (#57) #61

Merged
merged 2 commits into from
Nov 15, 2023
Merged

add qc_filter function (#57) #61

merged 2 commits into from
Nov 15, 2023

Conversation

Geet-George
Copy link
Owner

the self.qc attribute is still not available in the class. this will be added later on.
see #56 for a detailed explanation.

@Geet-George
add qc_filter function (#57)
d9306f1 
>
> the self.qc attribute is still not available in the class. this will be added later on.
> see #56 for a detailed explanation.
@Geet-George Geet-George linked an issue Nov 15, 2023 that may be closed by this pull request
qc_filter function #57
Closed
2 tasks
@Geet-George
remove apply_qc_checks and other fns with qc_check_ prefix (#57)
855d0b2 
with the new filter_qc function and the self.qc attrs (upcoming, see #56),
these unused functions are removed. #56 also explains how the whole procedure provides
more flexibility for the user in terms of QC selection of checks and filtering flags.
@Geet-George Geet-George marked this pull request as ready for review November 15, 2023 12:33
@Geet-George Geet-George merged commit d5ad242 into flexible-qc Nov 15, 2023
@Geet-George Geet-George deleted the filter-qc-function branch November 15, 2023 12:34
@Geet-George Geet-George mentioned this pull request Nov 15, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qc_filter function
1 participant
@Geet-George