Quicklooks #36
Quicklooks #36
Conversation
src/halodrops/plotting/quicklooks.py
Outdated
|
|
||
| # Select subset of satellite domain | ||
| img = pr.Image(m) | ||
| subset = img.subset_region_from_latlon_extents(extent, unit="degree") |
There was a problem hiding this comment.
Similar to how we get mean launch time from the dropsondes, I think the default extents should also be dependent on the actual launch locations, rather than a fixed bounding box.
src/halodrops/api/plotting.py
Outdated
|
|
||
|
|
||
| # Access satellite data | ||
| satellite_image = ql.get_satellite_data(**kwargs) |
There was a problem hiding this comment.
The **kwargs are not defined in the file. Also, they are not needed as their aim is to pass on the non-default arg values, which we will have the main function do. So, for this function call and all others in this script, it should work to simply have empty parentheses.
There was a problem hiding this comment.
This also should solve the CI failing.
There was a problem hiding this comment.
Thanks for the comments! I put it there as a place holder but realize how it would cause an error... I fixed this and also adjusted the default extents.
Quicklook script and draft of functions.