Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data structure #130

Merged
merged 16 commits into from
Aug 18, 2024
Merged

Data structure #130

merged 16 commits into from
Aug 18, 2024

Conversation

hgloeckner
Copy link
Collaborator

Adapted data structure from Nina

@hgloeckner hgloeckner requested a review from ninarobbins August 17, 2024 12:45
@hgloeckner hgloeckner marked this pull request as ready for review August 17, 2024 12:48
ninarobbins
ninarobbins reviewed Aug 17, 2024
View reviewed changes
Copy link
Collaborator

@ninarobbins ninarobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well for me, but there is one sonde that was detected as a floater and the landing time is set to the wrong date. But this might be my issue. I'll look more into it

src/halodrops/processor.py Outdated Show resolved Hide resolved
@ninarobbins ninarobbins mentioned this pull request Aug 17, 2024
Closed
@hgloeckner hgloeckner merged commit a895ca4 into Geet-George:main Aug 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninarobbins ninarobbins ninarobbins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hgloeckner @ninarobbins @Geet-George