-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1processing #122
L1processing #122
Conversation
The check for adding the postaspenfile without launch detect isn't useful anymore, as doing so currently has no defined behavior and it's expected that the pipeline filters no launch detect sondes prior to calling run_aspen. The other tests should still work the same. NOTE: This change ONLY adapts the existing tests to the new function name. It does not test if the processing actually does useful things. Testing this properly would require more complete testdata, which will be available after Geet-George#113 gets merged.
The way this is set up looks so nice! :) Thanks so much. One question: Currently for the package to work it would have to be connected to the internet to get the docker image right? Would it be possible that we add pull in the docker image as a dependency for the package to work? This means that in-flight processing would also be possible. |
That's a really good point. So if you run it once, it will be cached on your laptop and you can use the docker image offline, too. But I'll check whether and how it could be integrated into the first installation of halodrops 👍 |
Following Tobi's (@d70-t) advice, I'd start an issue on the offline processing of L0 to L1 as it's supposedly a feature creep to pull a docker image within a |
Yeah, makes sense. Also, best to merge this asap, I guess. The |
This PR adds the possibility to create level1 files from level0 via the ASPEN software that is run in a docker image. That way, it is not a prerequisite to process L0 files via ASPEN or BatchASPEN manually. If L1 files exist, they are used. If not, they will be created using the docker image
ghcr.io/atmdrops/aspenqc
generated and described in the repo aspenqc.The implementation includes adding the L0 to L1 processing in the pipeline dict and moving the
filter_no_launch_detect
function upfront. Also, several error messages are removed as (1) the launch_detect function was moved and (2) if the a-file does not exist, python will raise an AttributeError anyway.Closes #25.