add example data, edit config #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d70-t
reviewed
Aug 6, 2024
There was a problem hiding this comment.
This swp file maybe was committed by accident...
There was a problem hiding this comment.
You are right, thanks for pointing it out :)
Geet-George
reviewed
Aug 6, 2024
There was a problem hiding this comment.
This file needn't be there as part of sample data.
Geet-George
reviewed
Aug 6, 2024
There was a problem hiding this comment.
This too. I think all Level-2 directories can be removed.
There was a problem hiding this comment.
Yes - I removed them.
hgloeckner
force-pushed
the
add_example_data
branch
from
adaa208 to
63ead26
Compare
d70-t
added a commit
to tmieslinger/halodrops
that referenced
this pull request
Aug 7, 2024
The check for adding the postaspenfile without launch detect isn't useful anymore, as doing so currently has no defined behavior and it's expected that the pipeline filters no launch detect sondes prior to calling run_aspen. The other tests should still work the same. NOTE: This change ONLY adapts the existing tests to the new function name. It does not test if the processing actually does useful things. Testing this properly would require more complete testdata, which will be available after Geet-George#113 gets merged.
d70-t
added a commit
to tmieslinger/halodrops
that referenced
this pull request
Aug 7, 2024
The check for adding the postaspenfile without launch detect isn't useful anymore, as doing so currently has no defined behavior and it's expected that the pipeline filters no launch detect sondes prior to calling run_aspen. The other tests should still work the same. NOTE: This change ONLY adapts the existing tests to the new function name. It does not test if the processing actually does useful things. Testing this properly would require more complete testdata, which will be available after Geet-George#113 gets merged.
|
closes #123 too. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some example data and changed the path in the standard config such that people that clone the repo already get some dropsonde data to play with (also for us to be able to do tests later). The data I put is fairly arbitrary, so feel free to put different data