Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qc_filter function #57

Closed
2 tasks done
Tracked by #56
Geet-George opened this issue Nov 14, 2023 · 1 comment · Fixed by #61
Closed
2 tasks done
Tracked by #56

qc_filter function #57

Geet-George opened this issue Nov 14, 2023 · 1 comment · Fixed by #61

Comments

@Geet-George
Copy link
Owner

Geet-George commented Nov 14, 2023 •
edited
Loading

The current setup excludes the possibility for the user to flexibly select qc flags for different variables and then use these to create L2. To make it more customizable by the user, all qc-related attributes should be kept available for the user to choose from. A new function (maybe called qc_filter or something) can let the user to only select the sonde based on a list of filter_flags. This list will include elements that are qc-related attribute names, and if any of those are False, they will be filtered out from creating L2. The rest of the attributes will be ignored and will be propagated into L2 with their flag values. So, the most conservative QC filter would include all qc-related attributes in the filter_flag and not let any False value pass into L2. The most lenient QC filter would have an empty filter_flag list and allow all sondes pass into L2 (except no launch detected sonde, see commit 4c4085d) with their qc flag values propagated as variable values.

  • create qc_filter function
  • remove apply_qc_checks and functions with the prefix qc_check_
@Geet-George Geet-George mentioned this issue Nov 14, 2023
Closed
4 tasks
@Geet-George Geet-George changed the title qc_filter function The current setup excludes the possibility for the user to flexibly select qc flags for different variables and then use these to create L2. To make it more customizable by the user, all qc-related attributes should be kept available for the user to choose from. A new function (maybe called qc_filter or something) can let the user to only select the sonde based on a list of filter_flags. This list will include elements that are qc-related attribute names, and if any of those are False, they will be filtered out from creating L2. The rest of the attributes will be ignored and will be propagated into L2 with their flag values. So, the most conservative QC filter would include all qc-related attributes in the filter_flag and not let any False value pass into L2. The most lenient QC filter would have an empty filter_flag list and allow all sondes pass into L2 (except no launch detected sonde, see commit 4c4085d) with their qc flag values propagated as variable values. qc_filter function Nov 14, 2023
Geet-George added a commit that referenced this issue Nov 15, 2023
@Geet-George
add qc_filter function (#57)
d9306f1 
>
> the self.qc attribute is still not available in the class. this will be added later on.
> see #56 for a detailed explanation.
@Geet-George Geet-George linked a pull request Nov 15, 2023 that will close this issue
add qc_filter function (#57) #61
Merged
Geet-George added a commit that referenced this issue Nov 15, 2023
@Geet-George
remove apply_qc_checks and other fns with qc_check_ prefix (#57)
855d0b2 
with the new filter_qc function and the self.qc attrs (upcoming, see #56),
these unused functions are removed. #56 also explains how the whole procedure provides
more flexibility for the user in terms of QC selection of checks and filtering flags.
Geet-George added a commit that referenced this issue Nov 15, 2023
@Geet-George
Merge pull request #61 from Geet-George/filter-qc-function
d5ad242 
closes #57 and solves part of #56
@Geet-George
Copy link
Owner Author

Fixed by #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add qc_filter function (#57) Geet-George/halodrops
1 participant
@Geet-George