🐛 Listbox: select next/previous option when opening a listbox with no value #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcnamara-eng
force-pushed
the
bug/listbox-with-no-value-next-previous-option-active
branch
from
be4d346 to
60ec9cf
Compare
dmcnamara-eng
force-pushed
the
bug/listbox-with-no-value-next-previous-option-active
branch
from
60ec9cf to
860ae21
Compare
|
This is a great fix! Could we add a test case to verify the new, correct behavior so that we don't end up with a regression down the line? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What Changed & Why
Problem: In the case when a listbox has no default
@value, opening the listbox and navigating withArrowUp/ArrowDowndoes not function.Solution: Fix
setNextOptionActiveandsetPreviousOptionActivemethods to function even when there is no active option.👹 Before
😇 After
🌈 Testing
tests/dummy/app/components/listboxes/basic.hbs:3to have no default@valueember serveArrowUp/ArrowDownopens the listbox and navigates up and down the list.