GP 623: Revert sprintf so logged out rsvp functionality works

[jmarx]

Description of the Change

Removing sprintf so the logged out version of the RSVP block functions properly

Closes #623

How to test the Change

Try to RSVP to an event when logged out and ensure the log/register links work properly.

Changelog Entry

Fixed - Bug fix

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.

[carstingaxion]

OK, this took me a while, but yeah.

Bildschirmaufzeichnung.vom.01.04.2024.00.53.49.mp4

[carstingaxion]

Given the JS, I added originally some weeks ago:

{HtmlReactParser(
	sprintf(
		/* translators: %s: 'Login' (hyperlinked) */
		__(
			'You must %s to RSVP to events.',
			'gatherpress'
		),
		<a href={getFromGlobal('urls.loginUrl')}>
			{_x(
				'Login',
				'Context: You must ~ to RSVP to events.',
				'gatherpress'
			)}
		</a>
	)
)}

What I did not take into account, is that the <a> tag is going to be read as <react> component, not as a string, like sprintf expects. That resulted in the described error.

The easy fix took me a while, but it's just and only some nice little backticks.

{HtmlReactParser(
	sprintf(
		/* translators: %s: 'Login' (hyperlinked) */
		__(
			'You must %s to RSVP to events.',
			'gatherpress'
		),
		`<a href=${getFromGlobal('urls.loginUrl')}>
			${_x(
				'Login', 
				'Context: You must ~ to RSVP to events.', 
				'gatherpress'
			)}
		</a>`
	)
)}

Since React v17, Native 0.68 you can also just use curly braces inside of backticks: ${integerToString}. This will convert your embedded value to string.

People out there even created npm packages to solve this.

[carstingaxion]

I would suggest closing this in favor of #634

Best regards.