Merge pull request #619 from GatherPress/GP-605

Fix markup issue with self-closing div tag.
GatherPress · Mar 21, 2024 · 224d27c · 224d27c
2 parents 70cdbf9 + d3b5e48
commit 224d27c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/includes/core/classes/class-assets.php b/includes/core/classes/class-assets.php
@@ -264,7 +264,7 @@ public function editor_enqueue_scripts(): void {
 	 */
 	public function event_communication_modal(): void {
 		if ( get_post_type() === Event::POST_TYPE ) {
-			echo '<div id="gp-event-communication-modal" />';
+			echo '<div id="gp-event-communication-modal"></div>';
 		}
 	}
 

diff --git a/test/unit/php/includes/core/classes/class-test-assets.php b/test/unit/php/includes/core/classes/class-test-assets.php
@@ -108,7 +108,7 @@ public function test_event_communication_modal(): void {
 		$output = Utility::buffer_and_return( array( $instance, 'event_communication_modal' ) );
 
 		$this->assertSame(
-			'<div id="gp-event-communication-modal" />',
+			'<div id="gp-event-communication-modal"></div>',
 			$output,
 			'Failed to assert event_communication_modal output div.'
 		);