Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/194] 자유랭크 티어 정보 조회 #195

Merged
merged 2 commits into from
Feb 5, 2025
Merged

[Feat/194] 자유랭크 티어 정보 조회 #195

merged 2 commits into from
Feb 5, 2025

Conversation

rimi3226
Copy link
Contributor

@rimi3226 rimi3226 commented Feb 5, 2025

🚀 개요

자유랭크 티어 정보 조회

⏳ 작업 상세 내용

  • Member 엔티티 수정
  • 테스트 수정
  • RiotInfoService에서 자유랭크 불러오도록 수정
  • MemberFacadeService, MemberService에서 회원가입 로직 변경

📝 더 꼼꼼히 봐야할 부분

  • 없을 경우 체크

🔍 반드시 참고해야하는 변경 사항

  • 없을 경우 체크

@rimi3226 rimi3226 self-assigned this Feb 5, 2025
@rimi3226 rimi3226 linked an issue Feb 5, 2025 that may be closed by this pull request
2 tasks
@rimi3226 rimi3226 changed the title ✨ [Feat/194] 자유랭크 티어 정보 조회 [Feat/194] 자유랭크 티어 정보 조회 Feb 5, 2025
Copy link
Member

@Eunjin3395 Eunjin3395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum 필드 column설정만 추가되면 될 것 같습니다! 그리고 혹시 MatchingScoreCalculatorTest << 이거 테스트 디렉토리 unit 디렉토리로 이동 가능할까요?

@rimi3226 rimi3226 merged commit 18324be into develop Feb 5, 2025
1 check passed
@rimi3226 rimi3226 deleted the feat/194 branch February 5, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feat] 자유랭크 데이터 가져오기 / 회원
2 participants