ML-DSA: Add rejection sampling functions #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsella
commented
Nov 21, 2024
marsella
force-pushed
the
182-rejection-sampling
branch
from
b659790 to
247fe0d
Compare
| type Byte = [8] | ||
|
|
||
| /** | ||
| * Ring defined as the product of 255 elements in `Z q` used for NTT. |
There was a problem hiding this comment.
The array is still 256 for this correct since it is storing X^^0 as well? I get that this only goes up to X^^255 is that what you are implying by this being 255?
There was a problem hiding this comment.
Oh you're right, that was just a mistake on my part. The definition on page 6 is
| // Step 7 - 9. The recursive call here replaces the `while` loop. | ||
| a_hat' = case a_hat_j of | ||
| Some aj -> [aj] # (sample ctx) | ||
| None -> sample ctx |
There was a problem hiding this comment.
not sure if it is worth mentioning that the spec just overwrites this part of the "stream" on this case hence why it is safe to just skip writing it
There was a problem hiding this comment.
Good call, this was confusing when I came back to it. Added some docs.
I'm adding this now so I can write internal properties as I go and have confidence that they're correct.
marsella
force-pushed
the
182-rejection-sampling
branch
from
247fe0d to
3c3d2e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182.
Adds a few functions for rejection sampling.
I compared some of these to the versions in the IPD. The hash functions are the same. The
CoeffFrom...functions are the same.RejBoundedPolymatches. The seed forRejNTTPolyis a different size and I tried to compare them, but it didn't work. I feel pretty confident about my implementation, though, so I'm willing to wait to see if we get an error at a higher level.