Use SDLmain on Windows, rather than maintaining our own Impl. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready to go? |
|
Yup |
|
I just have one complaint about this. I don't like how the Windows-specific flags are moved to be grouped together. I get this reduces the number of |
|
No worries, will work on it over the weekend. |
playmer
force-pushed
the
playmer/Use_SDLMain
branch
from
867ade7 to
3b131a2
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently rely on a forked version of the SDLmain library on Windows, through usage of
SDL_win32_main.c. This is primarily just so we can place the std output redirects into AppData.Rather than maintain this entire file, I've updated the scripts to use SDLmain itself, and then within
onscripter.cppdisabled the SDLmain redirection and re-implemented the redirection to AppData. If we so desire it's also set up to allow us to expand redirection for platforms where it makes sense to do so. (Unix, Mac, maybe others.)SDLmain is fairly important for the more esoteric platforms, so trying to unify on using it's entry point is what led to me looking deeper at this.
This is missing some compatability ifdefs that allowed compiling for Windows CE. I could bring them back, but I have no way to actually test that codepath.
In addition I've sorted some of our options to not use redundant platform ifdefs.