Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extlib: convert libogg-1.3.5 to a Git submodule #71

Closed
wants to merge 1 commit into from

Conversation

SeanMcG
Copy link
Contributor

@SeanMcG SeanMcG commented Sep 14, 2024

Additionally, apply patches at build time to:

  • fix some undefined behaviour noted by UBsan (cherry-picked from upstream post-v1.3.5)

@SeanMcG
Copy link
Contributor Author

SeanMcG commented Sep 14, 2024

Same restriction as #69 , how to communicate git clone --recursive.

@SeanMcG SeanMcG marked this pull request as draft September 14, 2024 20:16
@SeanMcG SeanMcG force-pushed the ogg-submodule branch 4 times, most recently from 32866c0 to c959ef0 Compare September 21, 2024 18:24
@SeanMcG SeanMcG mentioned this pull request Oct 5, 2024
Additionally, apply patches at build time to:

- fix some undefined behaviour noted by UBsan (cherry-picked from upstream post-`v1.3.5`)
@SeanMcG SeanMcG marked this pull request as ready for review October 7, 2024 19:15
@SeanMcG
Copy link
Contributor Author

SeanMcG commented Oct 7, 2024

Same restriction as #69 , how to communicate git clone --recursive.

Handled skillfully by @playmer in #74.
This is ready for review now.

@SeanMcG
Copy link
Contributor Author

SeanMcG commented Oct 8, 2024

OK, talked with @Galladite27 on Discord and submodules is not the way we want to go for extlib. Closing.

@SeanMcG SeanMcG closed this Oct 8, 2024
@SeanMcG SeanMcG deleted the ogg-submodule branch October 9, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant