copy_on_error if symbolic link failed to be created #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglisse
approved these changes
Sep 20, 2024
| @@ -63,7 +63,9 @@ function( add_gudhi_symbolic_links GLOBBING_EXPRESSION ) | |||
| endif() | |||
| file(GLOB GUDHI_GLOB_FILES RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} ${GLOBBING_EXPRESSION}) | |||
| foreach(GUDHI_GLOB_FILENAME ${GUDHI_GLOB_FILES}) | |||
| file(CREATE_LINK "${CMAKE_CURRENT_SOURCE_DIR}/${GUDHI_GLOB_FILENAME}" "${CMAKE_CURRENT_BINARY_DIR}/${GUDHI_GLOB_FILENAME}" SYMBOLIC) | |||
| # COPY_ON_ERROR is activated because on windows, user needs to be root or in dev mode to be able to make symbolic links | |||
| # This case can be problematic, because if you modify the sources, build is still done on the copy | |||
There was a problem hiding this comment.
Ah, I was going to ask what happens in that case. I guess the link/copy is done during cmake generation, not during the actual build, so rerunning just make has no chance to redo the copy 😞
Bah, few developers use windows, even fewer will have non-working symlinks, even fewer will want partial rebuilds...
There was a problem hiding this comment.
Yes that's it, you need to cmake each time you do a modification. I was asking myself if we should explain it somewhere .
cf. https://www.howtogeek.com/16226/complete-guide-to-symbolic-links-symlinks-on-windows-or-linux/ Co-authored-by: Marc Glisse <marc.glisse@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix last issue of #1131 on windows where you need to have admin rights, or in developper mode to be able to make symbolic links.