Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Persistence Interval] fix of structural binding bug in windows compiler #1125

Conversation

hschreiber
Copy link
Collaborator

Just moved the get from the Gudhi::persistence_matrix namespace to a member method, as Windows confuses them with the ones in the std namespace otherwise. The git diff got very confused by the changes, the best is to probably just look directly at the file.

@mglisse
Copy link
Member

mglisse commented Aug 26, 2024

The git diff got very confused by the changes

This version of the diff is rather readable.

Copy link
Member

@mglisse mglisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative would be: do not specialize tuple_size, get rid of the unnecessary get members, reorder the members of the class, and rely on "case 3" of structured binding. But this version is good.

Co-authored-by: Marc Glisse <marc.glisse@inria.fr>
@VincentRouvreau VincentRouvreau merged commit 9aa70a7 into GUDHI:master Aug 27, 2024
7 checks passed
@VincentRouvreau VincentRouvreau added the 3.11.0 GUDHI version 3.11.0 label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11.0 GUDHI version 3.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants