Bump ASM to support Java 24 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires a Unimixins ASM bump as well. Tested in a modified nightly 559.
Should I push this PR, tag a version, and then bump both Unimixins and 3ify in GTNHG? |
|
@ah-OOG-ah is this ready to go or not? Undraft it if it is. |
I'm unsure of what order to bump things in. Does it have to go GTNHG gets Unimixins bump -> 3ify gets new GTNHG -> GTNHG gets bumped for 3ify or can I just merge this now and then bump both Unimixins and 3ify in GTNHG at once? |
|
gtnhg is for runClient, it would happen after the rest I believe. |
mitchej123
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in a modified nightly 559. Unimixins has been bumped, but I'm unsure where in the buildscript Unimixins is pulled in