Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2065 fix skip to h1 tab order #2072

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

scottqueen-bixal
Copy link
Contributor

PR Summary

Related Github Issue

Detailed Testing steps

Test reset focus, skip-to-h1 working

  • navigate to /death
  • tab into skip to main element
  • CLICK enter
  • Expect h1 to be focused
  • CLICK "Next"
  • tab into skip to main element
  • CLICK enter
  • Expect h1 to be focused

Test hash anchor in view

  • navigate to /death
  • navigate to first step
  • CLICK "Next"
  • CLICK first error
  • expect hash in url to update
  • expect hash to focus

@scottqueen-bixal scottqueen-bixal self-assigned this Jan 22, 2025
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review January 22, 2025 20:36
@scottqueen-bixal scottqueen-bixal merged commit c355c81 into dev Jan 22, 2025
5 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 2065-fix-skip-to-h1-tab-order branch January 22, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip to main is breaking on tab enter
1 participant