PXBF-2039-phpstan-fixes

[gchi25]

PR Summary

Related Github Issue

• Fixes PHPStan errors fixing #2039

Detailed Testing steps

• Navigate to node/add/bears_agency to create an agency
• Language: English
• Title: agency 1
• Summary: agency 1 summary
• Lede: agency 1 lede
• Save as Published
• Verify Generating both draft and published JSON data files
• Navigate to node/add/bears_criteria to create 3 criteria
• Language: English
• Title: criteria 1
• Criteria key: criteria_1
• ID: criteria_1
• Type: Radio
• Label criteria 1 label
• Name: criteria 1 name
• Values:
• Yes
• No
• Check [x] Has Child
• Child Dependency Option: Yes
• Save as Published
• Language: English
• Title: criteria 2
• Criteria key: criteria_2
• ID: criteria_2
• Type: Radio
• Label criteria 2 label
• Name: criteria 2 name
• Values:
• V1
• V2
• Check [x] Has Child
• Child Dependency Option: V1
• Save as Published
• Language: English
• Title: criteria 3
• Criteria key: criteria_3
• ID: criteria_3
• Type: Radio
• Label criteria 3 label
• Name: criteria 3 name
• Values:
• W1
• W2
• Empty [ ] Has Child
• Save as Published
• Navigate to node/add/bears_benefit to create a benefit
• Language: English
• Title: benefit 1
• Headline: benefit 1 headline
• Summary: benefit 1 summary
• Life Event Forms - check [x] Benefit finder: death of a loved one
• Agency: agency 1
• Source Link: https://www.ssa.gov/
• Benefit Eligibility
• Criteria Key: criteria 1
• Label: criteria 1 label
• Acceptable values: Yes
• Criteria Key: criteria 2
• Label: criteria 2 label
• Acceptable values: V1
• Criteria Key: criteria 3
• Label: criteria 3 label
• Acceptable values: Yes
• Save as Published
• Verify error message

• Update criteria 3 Acceptable values: W1
• Verify Generating both draft and published JSON data files
• Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
• Go to life event form Benefit finder: death of a loved one edit page
• In About you section, add 3 criteria
• Criteria Key: criteria 1
• Legend: criteria 1 legend
• Hint: criteria 1 hint
• Error Message: criteria 1 error
• Add criteria 2 as criteria 1 child
• Criteria Key: criteria 2
• Legend: criteria 2 legend
• Hint: criteria 2 hint
• Error Message: criteria 2 error
• Add criteria 3 as criteria 2 child
• Criteria Key: criteria 3
• Legend: criteria 3 legend
• Hint: criteria 3 hint
• Error Message: criteria 3 error
• Save as Published
• Verify error message

• Remove criteria 3
• Save as Published
• Verify Generating both draft and published JSON data files
• Navigate to benefit-finder/api/life-event/death
• Verify criteria 1 and criteria 2 in JSON data

• Navigate to benefit-finder/death
• Hard refresh web browser
• Click Start finding benefits
• Verify criteria 1 element
• Select Yes and verify criteria 2 element open
• Select No and verify criteria 2 element closed

• Select criteria 1 Yes
• Select criteria 2 V1
• Fill other form elements to get into Get your results page
• Get into "Benefits you did not qualify for" page
• Find the benefit "Benefit 1" to open
• Verify "Benefit 1" information

• Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
• Go to life event form "Benefit finder: death of a loved one" edit page
• Change Time Estimate, for example "4-8 minutes"
• Save as Draft
• Verify Generating draft JSON data files

• Navigate to benefit-finder/api/life-event/death?mode=draft
• Verify updated timeEstimate

• Navigate to benefit-finder/death?mode=draft
• Hard refresh web browser
• Verify updated Estimated time