Add config for identity_providers in local_info.xml #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sae126V
commented
Sep 13, 2024
gregcorbett
reviewed
Sep 13, 2024
Sae126V
force-pushed
the
GT-471-Shib/CheckIn-Token-reads-config-file
branch
3 times, most recently
from
694c0b2 to
7e7396c
Compare
Sae126V
force-pushed
the
GT-471-Shib/CheckIn-Token-reads-config-file
branch
from
7e7396c to
11b2a67
Compare
gregcorbett
reviewed
Nov 14, 2024
gregcorbett
reviewed
Nov 14, 2024
gregcorbett
reviewed
Nov 14, 2024
gregcorbett
reviewed
Nov 14, 2024
gregcorbett
reviewed
Nov 14, 2024
gregcorbett
reviewed
Nov 14, 2024
gregcorbett
reviewed
Nov 14, 2024
lib/Gocdb_Services/Config.php
Outdated
| $localInfo = $this->GetLocalInfoXML(); | ||
| $identityProviders = []; | ||
|
|
||
| if (!empty($localInfo->identity_providers->provider)) { |
There was a problem hiding this comment.
What happens here if identity_providers is omitted in it's entirety from the local_config.xml?
There was a problem hiding this comment.
identity_providers -> this is anyway optional. But if passed thru xml then it MUST have provider(This being idp, name, and other attributes) info.
This is just a safe check. Just in case if Null case is referring to any method(s) due to which it may cause errors.
gregcorbett
reviewed
Nov 14, 2024
gregcorbett
reviewed
Nov 14, 2024
gregcorbett
reviewed
Nov 14, 2024
gregcorbett
requested changes
Nov 14, 2024
|
rebasing for temporary testing in pre-production |
gregcorbett
force-pushed
the
GT-471-Shib/CheckIn-Token-reads-config-file
branch
7 times, most recently
from
eb5ddab to
277ad7e
Compare
- array_intersection was no longer suitable, as we want to extend the check to N required groups. - array_intersection would return a populated array even if only one required group was provided in entitlements, because that one group would be the interesection.
gregcorbett
force-pushed
the
GT-471-Shib/CheckIn-Token-reads-config-file
branch
from
fbd2e29 to
637dcd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GT-472 and GT-471