Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lights): several small fixes and improvements #47

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

Yoronex
Copy link
Member

@Yoronex Yoronex commented Feb 5, 2025

Description

Many improvements and fixes, big ans mall, for the lights controlled by Aurora.

  • Fixtures without "special" LEDs like white or amber now use the hex definition of a color to set their RGB values. This should make the output colors better match their expected tint.
  • Fixed moving heads not working synchronously in a line when they are expected to.
  • Fixed moving heads always having their color turned to white, even though this is not supposed to.
  • Fixed effect cleanup when switching from one effect to another.

Related issues/external references

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

@Yoronex Yoronex merged commit 2424776 into develop Feb 5, 2025
1 check passed
@Yoronex Yoronex deleted the fix/lights-fixes branch February 5, 2025 22:03
Yoronex added a commit that referenced this pull request Feb 5, 2025
* fix(moving-heads): not working synchronous in a line

* fix(moving-heads): light always on

* feat(lights-effects): use hex colors if pars have only RGB LEDs

* fix(lights-effects): clean up when effect is destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant