feat(effects-controller): add support for simple effects controller with preconfigured buttons #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoronex
added a commit
that referenced
this pull request
Feb 5, 2025
…ith preconfigured buttons (#40) * chore(lights): make pattern enum string-based * chore(lights): rename predefined effect to track effect * feat(effects-controller): add endpoints for effect controller buttons * fix(effects-controller): small issues and mistakes * feat(lights-controller): add reset button * feat(lights-effects): allow changing colors mid-effect * fix(lights-effects): deadlock when passing undefined as color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the simpler effects controller in the backoffice. Basically, this PR implements a new
LighstPredefinedEffectentity, which stores a preconfigured button on the controller. This button change change colors, apply effects, turn on/off lights switches, turn on/off the strobe, etc. With this, the user can configure a "board" with buttons that do different things.Related issues/external references
Fixes #33.
Types of changes