feat(lights)!: remove individual fixture requirements and constraints #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a large refactor of the processing of fixture settings from colors and positions to actual DMX channel values. The new implementation uses a Strategy design pattern to neatly separate different responsibilities. Then, with the improved framework, the following features are added:
For example, each fixture on the disco floor only needs 3 channels instead of the previous Aurora-default of 16. This allows for 170 disco floor fixtures in one DMX universe, instead of 32 (increasing the floor size from 8m2 to 42m2).
It does include breaking changes, as multiple database columns have been renamed. This is caused by moving these columns to separate objects.
Related issues/external references
Fixes #35.
Fixes #36.
Includes refactoring work necessary for #31 and #29.
Types of changes