Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(poster): Add other Hubble poster handlers #23

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

SuperVK
Copy link
Member

@SuperVK SuperVK commented Jan 7, 2025

Adds other Hubble posters, namely closed and last call

The handlers are just empty classes, not the most pretty but I couldn't find another way to make this work

Description

Related issues/external references

Types of changes

  • New feature (non-breaking change which adds functionality)

@Yoronex
Copy link
Member

Yoronex commented Jan 21, 2025

@SuperVK can you please resolve the failing build, so this PR can be merged?

@JustSamuel JustSamuel force-pushed the feature/other-hubble-handler branch from 3b59d8e to 83e903a Compare January 21, 2025 16:20
Co-authored-by: Samuel <s.a.j.oosterholt@student.tue.nl>
@JustSamuel JustSamuel force-pushed the feature/other-hubble-handler branch from 83e903a to efa93c5 Compare January 21, 2025 16:34
@JustSamuel JustSamuel requested a review from Yoronex January 21, 2025 16:35
@JustSamuel
Copy link
Contributor

@Yoronex fixed it for you

@JustSamuel
Copy link
Contributor

@Yoronex also note that releasing (pushing to our own pkg hub) doesn't work yet.

@SuperVK SuperVK merged commit 7be3f7e into develop Jan 22, 2025
2 checks passed
@SuperVK SuperVK deleted the feature/other-hubble-handler branch January 22, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants