From fd3c6f503d9890e4fd9a90351b4d751b9098f0eb Mon Sep 17 00:00:00 2001
From: Roy Kakkenberg <me@roykakkenberg.nl>
Date: Tue, 4 Feb 2025 22:50:21 +0100
Subject: [PATCH] fix(lights-effects): movement effects always using some
 default props

---
 src/modules/lights/effects/movement/classic-rotate.ts | 4 ++--
 src/modules/lights/effects/movement/search-light.ts   | 4 ++--
 src/modules/lights/effects/movement/table-rotate.ts   | 5 ++++-
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/modules/lights/effects/movement/classic-rotate.ts b/src/modules/lights/effects/movement/classic-rotate.ts
index 51434e7..db48fa7 100644
--- a/src/modules/lights/effects/movement/classic-rotate.ts
+++ b/src/modules/lights/effects/movement/classic-rotate.ts
@@ -27,8 +27,8 @@ export default class ClassicRotate extends BaseRotate<ClassicRotateProps> {
     super(
       lightsGroup,
       {
-        cycleTime: DEFAULT_CYCLE_TIME,
-        offsetFactor: DEFAULT_OFFSET_FACTOR,
+        cycleTime: props.cycleTime || DEFAULT_CYCLE_TIME,
+        offsetFactor: props.offsetFactor || DEFAULT_OFFSET_FACTOR,
       },
       { pattern: props.pattern, direction: props.direction },
     );
diff --git a/src/modules/lights/effects/movement/search-light.ts b/src/modules/lights/effects/movement/search-light.ts
index 9ca4e50..77975fc 100644
--- a/src/modules/lights/effects/movement/search-light.ts
+++ b/src/modules/lights/effects/movement/search-light.ts
@@ -36,8 +36,8 @@ export default class SearchLight extends BaseRotate<SearchLightProps> {
     super(
       lightsGroup,
       {
-        cycleTime: DEFAULT_CYCLE_TIME,
-        offsetFactor: DEFAULT_OFFSET_FACTOR,
+        cycleTime: props.cycleTime || DEFAULT_CYCLE_TIME,
+        offsetFactor: props.offsetFactor || DEFAULT_OFFSET_FACTOR,
       },
       { pattern: props.pattern, direction: props.direction },
     );
diff --git a/src/modules/lights/effects/movement/table-rotate.ts b/src/modules/lights/effects/movement/table-rotate.ts
index ab77c43..dac55b7 100644
--- a/src/modules/lights/effects/movement/table-rotate.ts
+++ b/src/modules/lights/effects/movement/table-rotate.ts
@@ -25,7 +25,10 @@ export default class TableRotate extends BaseRotate<TableRotateProps> {
   constructor(lightsGroup: LightsGroup, props: TableRotateProps) {
     super(
       lightsGroup,
-      { cycleTime: DEFAULT_CYCLE_TIME, offsetFactor: DEFAULT_OFFSET_FACTOR },
+      {
+        cycleTime: props.cycleTime || DEFAULT_CYCLE_TIME,
+        offsetFactor: props.offsetFactor || DEFAULT_OFFSET_FACTOR,
+      },
       { pattern: props.pattern, direction: props.direction },
     );
     this.props = props;