fix(lights-effects): movement effects always using some default props

GEWIS · Feb 4, 2025 · fd3c6f5 · fd3c6f5
1 parent d7ed90e
commit fd3c6f5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/modules/lights/effects/movement/classic-rotate.ts b/src/modules/lights/effects/movement/classic-rotate.ts
@@ -27,8 +27,8 @@ export default class ClassicRotate extends BaseRotate<ClassicRotateProps> {
     super(
       lightsGroup,
       {
-        cycleTime: DEFAULT_CYCLE_TIME,
-        offsetFactor: DEFAULT_OFFSET_FACTOR,
+        cycleTime: props.cycleTime || DEFAULT_CYCLE_TIME,
+        offsetFactor: props.offsetFactor || DEFAULT_OFFSET_FACTOR,
       },
       { pattern: props.pattern, direction: props.direction },
     );

diff --git a/src/modules/lights/effects/movement/search-light.ts b/src/modules/lights/effects/movement/search-light.ts
@@ -36,8 +36,8 @@ export default class SearchLight extends BaseRotate<SearchLightProps> {
     super(
       lightsGroup,
       {
-        cycleTime: DEFAULT_CYCLE_TIME,
-        offsetFactor: DEFAULT_OFFSET_FACTOR,
+        cycleTime: props.cycleTime || DEFAULT_CYCLE_TIME,
+        offsetFactor: props.offsetFactor || DEFAULT_OFFSET_FACTOR,
       },
       { pattern: props.pattern, direction: props.direction },
     );

diff --git a/src/modules/lights/effects/movement/table-rotate.ts b/src/modules/lights/effects/movement/table-rotate.ts
@@ -25,7 +25,10 @@ export default class TableRotate extends BaseRotate<TableRotateProps> {
   constructor(lightsGroup: LightsGroup, props: TableRotateProps) {
     super(
       lightsGroup,
-      { cycleTime: DEFAULT_CYCLE_TIME, offsetFactor: DEFAULT_OFFSET_FACTOR },
+      {
+        cycleTime: props.cycleTime || DEFAULT_CYCLE_TIME,
+        offsetFactor: props.offsetFactor || DEFAULT_OFFSET_FACTOR,
+      },
       { pattern: props.pattern, direction: props.direction },
     );
     this.props = props;