Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/eslint prettier shared configs #13

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

Gijsdeman
Copy link
Contributor

This pull request moves from personal eslint and prettier configs to the shared GEWIS' ones.

Description

For ease of maintainability, eslint and prettier configs are slowly moved to a central repository. This pull requests is a test and proof of concept of using such shared configs.

Types of changes

  • New feature (non-breaking change which adds functionality)

@Gijsdeman
Copy link
Contributor Author

Gijsdeman commented Nov 3, 2024

Should wait until a new release of eslint-configs to actually merge this.

This pull request is ready to merge; but we should wait until the develop branch has been merged with main to check if the workflows work as expected.

@Gijsdeman Gijsdeman force-pushed the Refactor/eslint-prettier-shared-configs branch 2 times, most recently from 402c5b6 to 2806fb4 Compare November 5, 2024 18:54
@Gijsdeman Gijsdeman force-pushed the Refactor/eslint-prettier-shared-configs branch from 2806fb4 to 982ceb8 Compare November 5, 2024 19:00
@Gijsdeman Gijsdeman marked this pull request as ready for review November 5, 2024 19:01
@Gijsdeman Gijsdeman merged commit 10e8b20 into develop Nov 6, 2024
3 checks passed
@Gijsdeman Gijsdeman deleted the Refactor/eslint-prettier-shared-configs branch November 6, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant