Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GEOSradiation_GridComp v1.6.0 #722

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

mathomp4
Copy link
Member

This PR updates to GEOSradiation_GridComp v1.6.0. This release of GEOSradiation_GridComp has a few updates (see GEOS-ESM/GEOSradiation_GridComp#27):

  1. The Load Balancing code in Solar was reworked to not call MAPL_LoadBalance code when not load balancing. Previously, it used a naive approach which still did MPI calls for no reason. Now it avoids that.
  2. Adds the ability to change the MaxPasses parameter when loadbalancing via the SOLAR_LB_MAX_PASSES: AGCM.rc resource. By default it uses 100 which is the default in MAPL
  3. Fixes for the profilers. Testing by @wmputman and @atrayano at high-res found that some columns over an integration period might not have, say, any clouds. This would then avoid some code in RRTMG which meant some timers were not turned on-off on some processes. This lead to deadlocks in Finalize when the timers were outputted. Likewise, when the loadbalaning code was updated, it found that processes without lit points also avoided some profiler calls.

All testing shows this is zero-diff to GEOSradiaiton_GridComp v1.5.1

@mathomp4 mathomp4 requested a review from a team as a code owner December 15, 2023 14:50
@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 15, 2023
@mathomp4 mathomp4 self-assigned this Dec 15, 2023
@sdrabenh sdrabenh merged commit d37fe9e into main Jan 5, 2024
4 checks passed
@sdrabenh sdrabenh deleted the feature/mathomp4/update-rad-1.6.0 branch January 5, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants