Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/profile style changes #53

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Refactor/profile style changes #53

merged 4 commits into from
Dec 2, 2020

Conversation

idsilva
Copy link

@idsilva idsilva commented Dec 2, 2020

Issue

Add loaders into profile and product sections

  • To review, clone branch and run start scripts
  • While profile / product section loads, uploader shows up.
  • Includes refactor of product / profile directory
  • Converts generic-components as module.

Ignacio S added 4 commits December 2, 2020 10:15
Fix. Adds icon to title
8e63db7
Refactor:
3f29a18 
Create module of Generic Component
Add generic  loaderModal
Add Loader to products
Refactor: creates profile module.
acceb71
Fix: corrects missing key
6038a7d 
Case names in ProfileScreen
@idsilva idsilva requested a review from smunozp December 2, 2020 15:49
@smunozp smunozp merged commit e5f0cbb into develop Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smunozp smunozp Awaiting requested review from smunozp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idsilva @smunozp