refactor(core): just for satify @flavien-chenu

G-Epitech · Apr 2, 2024 · fd43875 · fd43875
1 parent 0041e64
commit fd43875
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 12 deletions.
diff --git a/core/CMakeLists.txt b/core/CMakeLists.txt
@@ -1,8 +1,8 @@
-add_executable(${PROJECT_NAME}    
+add_executable(arcade
   main.cpp
 )
 
-target_include_directories(${PROJECT_NAME} PUBLIC ${CMAKE_CURRENT_LIST_DIR}/..)
-target_include_directories(${PROJECT_NAME} PUBLIC ${CMAKE_CURRENT_LIST_DIR}/src)
+target_include_directories(arcade PUBLIC ${CMAKE_CURRENT_LIST_DIR}/..)
+target_include_directories(arcade PUBLIC ${CMAKE_CURRENT_LIST_DIR}/src)
 
 add_subdirectory(src)
diff --git a/core/src/CMakeLists.txt b/core/src/CMakeLists.txt
@@ -1,4 +1,4 @@
-target_sources(${CMAKE_PROJECT_NAME} PRIVATE
+target_sources(arcade PRIVATE
     Core.cpp
     Core.hpp
 )

diff --git a/core/src/Core.cpp b/core/src/Core.cpp
@@ -252,7 +252,7 @@ void Core::_handleWindowResize()
     std::cout << "Window resized" << std::endl;
 }
 
-void Core::_handleKeyBoardEvents(std::vector<events::EventPtr> &events, std::shared_ptr<components::IKeyboardComponent> &component)
+void Core::_handleKeyboardEvents(std::vector<events::EventPtr> &events, std::shared_ptr<components::IKeyboardComponent> &component)
 {
     for (auto &event : events) {
         auto type = event->getType();
@@ -354,7 +354,7 @@ void Core::_handleComponentEvents(std::vector<events::EventPtr> &events, std::sh
 
     if (type == components::KEYBOARD) {
         auto keyboard = std::dynamic_pointer_cast<components::IKeyboardComponent>(component);
-        this->_handleKeyBoardEvents(events, keyboard);
+        this->_handleKeyboardEvents(events, keyboard);
     }
     if (type == components::TEXT || type == components::TEXTURE) {
         auto displayable = std::dynamic_pointer_cast<components::IDisplayableComponent>(component);

diff --git a/core/src/Core.hpp b/core/src/Core.hpp
@@ -34,7 +34,6 @@ class Core {
          */
         void run();
 
-    protected:
     private:
 
         typedef struct {
@@ -157,7 +156,7 @@ class Core {
          * @param events Events to handle
          * @param component The keyboard component
          */
-        void _handleKeyBoardEvents(std::vector<events::EventPtr> &events, std::shared_ptr<components::IKeyboardComponent> &component);
+        void _handleKeyboardEvents(std::vector<events::EventPtr> &events, std::shared_ptr<components::IKeyboardComponent> &component);
 
         /**
          * @brief Handle the displayable events
@@ -265,5 +264,10 @@ class Core {
          */
         components::IKeyboardComponent::KeyData _convertKeyPressData(events::IKeyEvent::KeyType type, events::IKeyEvent::KeyCode code);
 
+        /**
+         * @brief Handle the mouse button press event
+         * 
+         * @param event The mouse button event
+         */
         void _handleSoundComponent(std::shared_ptr<components::ISoundComponent> &component);
 };
diff --git a/core/src/exception/CMakeLists.txt b/core/src/exception/CMakeLists.txt
@@ -1,4 +1,4 @@
-target_sources(${CMAKE_PROJECT_NAME} PRIVATE
+target_sources(arcade PRIVATE
     ArcadeError.cpp
     ArcadeError.hpp
 )
diff --git a/core/src/loader/CMakeLists.txt b/core/src/loader/CMakeLists.txt
@@ -1,4 +1,4 @@
-target_sources(${CMAKE_PROJECT_NAME} PRIVATE
+target_sources(arcade PRIVATE
     Loader.cpp
     Loader.hpp
 )
diff --git a/core/src/types/CMakeLists.txt b/core/src/types/CMakeLists.txt
@@ -1,3 +1,3 @@
-target_sources(${CMAKE_PROJECT_NAME} PRIVATE
+target_sources(arcade PRIVATE
     Providers.hpp
 )
diff --git a/core/src/utils/DLLoader/CMakeLists.txt b/core/src/utils/DLLoader/CMakeLists.txt
@@ -1,3 +1,3 @@
-target_sources(${CMAKE_PROJECT_NAME} PRIVATE
+target_sources(arcade PRIVATE
     DLLoader.cpp
 )