refactor(graphics:sfml): move templated method to header file as requested

Author: flavien-chenu

graphics/sfml/src/window/Renderer.cpp

@@ -133,15 +133,3 @@ Vector2f Renderer::_entityPixelsPosition(const Vector2i &position) {
         static_cast<float>(pixels.y)
     };
 }
-
-template<class From, class To>
-std::shared_ptr<To> Renderer::_castOrThrow(std::shared_ptr<From> from) {
-    std::shared_ptr<To> to = std::dynamic_pointer_cast<To>(from);
-    if (!to) {
-        throw WindowException(
-            "Failed to cast shared pointer of:" + std::string(typeid(from).name()) + " to " + typeid(to).name(),
-            "SFML Library Renderer::_castOrThrow"
-        );
-    }
-    return to;
-}

graphics/sfml/src/window/Renderer.hpp

@@ -11,6 +11,7 @@
 #include "shared/graphics/ITexture.hpp"
 #include "shared/graphics/types/TextureProps.hpp"
 #include "shared/graphics/types/TextProps.hpp"
+#include "common/exceptions/WindowException.hpp"
 
 namespace arcade::graphics::sfml::window {
     class Renderer;
@@ -42,9 +43,6 @@ class arcade::graphics::sfml::window::Renderer {
     sf::Text _text;
     sf::Sprite _sprite;
 
-    template<class From, class To>
-    static std::shared_ptr<To> _castOrThrow(std::shared_ptr<From> from);
-
     /**
      * @brief Reset the text properties
      * @param text Text to reset
@@ -76,10 +74,10 @@ class arcade::graphics::sfml::window::Renderer {
     );
 
     /**
- * @brief Align the text
- * @param align Text alignment
- * @param entitySize Entity size
- */
+     * @brief Align the text
+     * @param align Text alignment
+     * @param entitySize Entity size
+     */
     void _textAlign(const shared::graphics::TextAlign &align, const shared::types::Vector2i &entitySize);
 
     /**
@@ -92,4 +90,23 @@ class arcade::graphics::sfml::window::Renderer {
      * @param props Texture properties
      */
     void _setTextureRectAndScale(const shared::graphics::TextureProps &props);
-};
+
+    /**
+     * @brief Cast a shared pointer from a type to another
+     * @tparam From Type from which to cast
+     * @tparam To Type to which cast
+     * @param from Value to cast
+     * @return Casted value
+     */
+    template<class From, class To>
+    static std::shared_ptr<To> _castOrThrow(std::shared_ptr<From> from) {
+        std::shared_ptr<To> to = std::dynamic_pointer_cast<To>(from);
+        if (!to) {
+            throw common::exceptions::WindowException(
+                "Failed to cast shared pointer of:" + std::string(typeid(from).name()) + " to " + typeid(to).name(),
+                "SFML Library Renderer::_castOrThrow"
+            );
+        }
+        return to;
+    };
+};