Skip to content

Commit

Permalink
fix(dlloader): remove useless references
Browse files Browse the repository at this point in the history
  • Loading branch information
Yann-Masson committed Apr 2, 2024
1 parent 8ad84c6 commit 168b3ba
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions core/src/loader/Loader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@ Loader::Loader() {}

Loader::~Loader() {}

shared::types::LibraryType Loader::_getLibraryGetter(const std::string &filepath, std::shared_ptr<DLLoader> &dlLoader) {
shared::types::LibraryType Loader::_getLibraryGetter(const std::string &filepath, std::shared_ptr<DLLoader> dlLoader) {
shared::types::LibraryTypeGetter getter = nullptr;

getter = dlLoader->loadSymbol<shared::types::LibraryTypeGetter>(SHARED_STRINGIFY(SHARED_LIBRARY_TYPE_GETTER_NAME));
return getter();
}

void Loader::_loadGameLibrary(const std::string &filepath, std::shared_ptr<DLLoader> &dlLoader) {
void Loader::_loadGameLibrary(const std::string &filepath, std::shared_ptr<DLLoader> dlLoader) {
shared::types::GameProviderGetter game = nullptr;

game = dlLoader->loadSymbol<shared::types::GameProviderGetter>(SHARED_STRINGIFY(SHARED_GAME_PROVIDER_GETTER_NAME));
this->_gamesLibraries.push_back(std::unique_ptr<shared::games::IGameProvider>(game()));
this->_libraries.push_back(dlLoader);
}

void Loader::_loadGraphicsLibrary(const std::string &filepath, std::shared_ptr<DLLoader> &dlLoader) {
void Loader::_loadGraphicsLibrary(const std::string &filepath, std::shared_ptr<DLLoader> dlLoader) {
shared::types::GraphicsProviderGetter graphics = nullptr;

graphics = dlLoader->loadSymbol<shared::types::GraphicsProviderGetter>(SHARED_STRINGIFY(SHARED_GRAPHICS_PROVIDER_GETTER_NAME));
Expand Down
6 changes: 3 additions & 3 deletions core/src/loader/Loader.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,21 +60,21 @@ class Loader {
* @param loader DLLoader
* @return getter function
*/
shared::types::LibraryType _getLibraryGetter(const std::string &filepath, std::shared_ptr<DLLoader> &loader);
shared::types::LibraryType _getLibraryGetter(const std::string &filepath, std::shared_ptr<DLLoader> loader);

/**
* @brief Load a game library
* @param filepath file path of the library
* @param loader DLLoader
*/
void _loadGameLibrary(const std::string &filepath, std::shared_ptr<DLLoader> &loader);
void _loadGameLibrary(const std::string &filepath, std::shared_ptr<DLLoader> loader);

/**
* @brief Load a graphics library
* @param filepath file path of the library
* @param loader DLLoader
*/
void _loadGraphicsLibrary(const std::string &filepath, std::shared_ptr<DLLoader> &loader);
void _loadGraphicsLibrary(const std::string &filepath, std::shared_ptr<DLLoader> loader);

/**
* @brief Throw an error when loading a library
Expand Down

0 comments on commit 168b3ba

Please sign in to comment.