メイン画面の画像の一覧表示 #45
Open
メイン画面の画像の一覧表示 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
モック用のjpgファイルまでpushしています... |
zekuta-x
requested changes
Feb 17, 2023
Comment on lines
1
to
21
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "copper_wire_rack.jpg", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
There was a problem hiding this comment.
この辺のやつ全部ローカルからimportしたときに出るやつなので削除お願いします
Comment on lines
1
to
21
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "garden_strand.jpg", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Comment on lines
1
to
21
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "gatsby_hat.jpg", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Comment on lines
1
to
21
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "gilt_desk_trio.jpg", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Comment on lines
1
to
21
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "shrug_bag.jpg", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
| .cornerRadius(20) | ||
|
|
||
| VStack(alignment: .leading, spacing: 4) { | ||
| Text(title).font(.system(size: 14)).padding(.leading, 10) |
There was a problem hiding this comment.
コンテンツのとこもそうだけど、だいぶ前に作ったatomのtextから引用しないとアプリ内文字に統一感なくなるのでお願いします
| @@ -9,12 +9,12 @@ import SwiftUI | |||
|
|
|||
| struct FloatingActionButtonView: View { | |||
| Text(content).font(.system(size: 14)).padding(.leading, 10) | ||
| } | ||
| .frame(width: 150, height: 50, alignment: .leading) | ||
| .background(Color.white) |
Comment on lines
46
to
58
| let data: [CustomCell] = [ | ||
| CustomCell(title: "garden_strand", content: "ネックレス", imgPath: "garden_strand"), | ||
| CustomCell(title: "gatsby_hat", content: "ハット", imgPath: "gatsby_hat"), | ||
| CustomCell(title: "stella_sunglasses", content: "グラス", imgPath: "stella_sunglasses"), | ||
| CustomCell(title: "strut_earrings", content: "イヤリング", imgPath: "strut_earrings"), | ||
| CustomCell(title: "vagabond_sack", content: "リュックサック", imgPath: "vagabond_sack"), | ||
| CustomCell(title: "varsity_socks", content: "ソックス", imgPath: "varsity_socks"), | ||
| CustomCell(title: "whitey_belt", content: "ベルト", imgPath: "whitey_belt"), | ||
| CustomCell(title: "copper_wire_rack", content: "ラック", imgPath: "copper_wire_rack"), | ||
| CustomCell(title: "gilt_desk_trio", content: "小物入れ", imgPath: "gilt_desk_trio"), | ||
| CustomCell(title: "shrug_bag", content: "バッグ", imgPath: "shrug_bag") | ||
|
|
||
| ] |
There was a problem hiding this comment.
プレビューは下の CollectionView_Previews: PreviewProvider に書いてほしい
Comment on lines
33
to
36
| .frame(width: 150, height: 152) | ||
| .overlay( | ||
| RoundedRectangle(cornerRadius: 20) | ||
| .stroke(Color.gray, lineWidth: 1) |
There was a problem hiding this comment.
figma上では枠線がないような気がする
白にするのが良いかと
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #11
機能説明
ex.) hoge機能の実装をしました、huga機能の修正をしました などを箇条書きで記述
懸念事項
ex.) iPhoneSEだとUIが崩れる、swiftlintで注意が出る などの懸念と対策を箇条書きで記述
スクリーンショット
セルフレビュー
ex.)
(あれば)レビュー，チェックしてほしい部分
ex.)