-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move dev dependencies to workspace #6966
Conversation
CodSpeed Performance ReportMerging #6966 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Minor improvement commented on the previous PR: #6955 (comment)
Not required though.
Apparently workspace members can only inherit workspace dependencies, not dev dependencies (even as dev dependencies). I can't find it in the documentation anywhere, but if you try adding it to a dev-dependencies section in the root Cargo.toml, and use
|
Interesting I did not know about this; thanks! |
Description
Moves dev dependencies to the workspace Cargo.toml for consistent versions in tests.
Inspired by #6955
Checklist
Breaking*
orNew Feature
labels where relevant.