Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move dev dependencies to workspace #6966

Merged
merged 4 commits into from
Feb 28, 2025
Merged

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Feb 26, 2025

Description

Moves dev dependencies to the workspace Cargo.toml for consistent versions in tests.

Inspired by #6955

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #6966 will not alter performance

Comparing sophie/dev-dep-workspace (bddc310) with master (1c3183a)

Summary

✅ 22 untouched benchmarks

@sdankel sdankel marked this pull request as ready for review February 27, 2025 23:15
@sdankel sdankel requested review from a team as code owners February 27, 2025 23:15
Copy link
Contributor

@zees-dev zees-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Minor improvement commented on the previous PR: #6955 (comment)
Not required though.

@sdankel
Copy link
Member Author

sdankel commented Feb 28, 2025

LGTM 👍

Minor improvement commented on the previous PR: #6955 (comment) Not required though.

Apparently workspace members can only inherit workspace dependencies, not dev dependencies (even as dev dependencies). I can't find it in the documentation anywhere, but if you try adding it to a dev-dependencies section in the root Cargo.toml, and use workspace = true in a member manifest, you'll see an error like:

dependency.wiremock` was not found in `workspace.dependencies`

@sdankel sdankel enabled auto-merge (squash) February 28, 2025 00:34
@sdankel sdankel requested a review from JoshuaBatty February 28, 2025 00:35
@sdankel sdankel merged commit 597ecfb into master Feb 28, 2025
42 checks passed
@sdankel sdankel deleted the sophie/dev-dep-workspace branch February 28, 2025 00:44
@zees-dev
Copy link
Contributor

LGTM 👍
Minor improvement commented on the previous PR: #6955 (comment) Not required though.

Apparently workspace members can only inherit workspace dependencies, not dev dependencies (even as dev dependencies). I can't find it in the documentation anywhere, but if you try adding it to a dev-dependencies section in the root Cargo.toml, and use workspace = true in a member manifest, you'll see an error like:

dependency.wiremock` was not found in `workspace.dependencies`

Interesting I did not know about this; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants