Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce GlobalVar akin to LocalVar and introduce get_global instruction similar to get_local. #6928

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Introduce GlobalVar akin to LocalVar and introduce get_global instruction similar to get_local. #6928

wants to merge 44 commits into from
+852 −303

Conversation

vaivaswatha
Copy link
Contributor

2nd Step as part of #6351, in continuation to #6896

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 14, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #6928 will not alter performance

Comparing vaivaswatha/ir_consts_2 (a68e7ee) with master (ba7c4a9)

Summary

✅ 22 untouched benchmarks

@vaivaswatha vaivaswatha self-assigned this Feb 14, 2025
@vaivaswatha vaivaswatha changed the base branch from master to vaivaswatha/ir_consts_1 February 19, 2025 06:24
@vaivaswatha
Copy link
Contributor Author

@ironcev except for some annoying typos (which I don't know what to do about), CI seems to work. Can you please re-review?

@ironcev
Copy link
Member

ironcev commented Mar 3, 2025

@vaivaswatha Regarding the typos, adding uage to .typos.toml should fix that part. And the event.typ in the LSP definitely looks like a typo it should be event.type, or? I assume fixing that identifier in LSP code in this PR is fine.

ironcev
ironcev requested changes Mar 3, 2025
View reviewed changes
ironcev
ironcev previously approved these changes Mar 3, 2025
View reviewed changes
@vaivaswatha vaivaswatha requested a review from ironcev March 3, 2025 12:36
@vaivaswatha vaivaswatha enabled auto-merge (squash) March 3, 2025 12:36
@vaivaswatha vaivaswatha requested a review from a team March 4, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcev ironcev ironcev approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@vaivaswatha vaivaswatha

Labels
compiler: ir IRgen and sway-ir including optimization passes compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaivaswatha @ironcev @IGI-111