-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Safety when introspecting transaction inputs #6405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K1-R1
previously approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; just an optional nit
alfiedotwtf
approved these changes
Aug 16, 2024
SwayStar123
approved these changes
Aug 16, 2024
K1-R1
approved these changes
Aug 16, 2024
IGI-111
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the
inputs.sw
library of the std-lib, if a bad input was given to the functions or a transaction did not exist, the functions would revert. Instead, they now return options so error may be caught.Fixes
input_pointer
now returns a pointer over au64
and is private.Breaking
There are a number of breaking changes in function return types.
predicate_address()
now returns anOption<Address>
.Before:
After
input_type()
now returns anOption<Input>
.Before:
After:
input_predicate_data()
now returns anOption<T>
.Before:
After:
input_predicate()
now returns anOption<Bytes>
.Before:
After:
input_message_sender()
now returns anOption<Address>
.Before:
After:
input_message_recipient()
now returns anOption<Address>
.Before:
After:
input_message_data_length()
now returns anOption<u64>
.Before:
After:
input_message_data()
now returns anOption<Bytes>
.Before:
After:
input_pointer()
now returns anOption<raw_ptr>
and is privateBefore:
After:
input_message_nonce()
now returns anOption<b256>
Before:
After:
Closes #6216
Checklist
Breaking*
orNew Feature
labels where relevant.