Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forc build panic when sway package folder contains dot #5448

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

Halimao
Copy link
Contributor

@Halimao Halimao commented Jan 10, 2024

Description

Close #5434

Since canonical_manifest_dir is a dir, not a file, to get the last-level dir name, we should use file_name() instead of file_stem.

image

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Halimao Halimao changed the title fix: fix forc build panic when sway package folder contains dot fix: forc build panic when sway package folder contains dot Jan 10, 2024
@kayagokalp kayagokalp added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged forc labels Jan 10, 2024
@kayagokalp kayagokalp requested review from a team January 10, 2024 12:45
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Halimao, great catch! Can we add a test as @crodas mentioned? I added couple of options where to place it in that review

@Halimao
Copy link
Contributor Author

Halimao commented Jan 10, 2024

Thanks for the PR @Halimao, great catch! Can we add a test as @crodas mentioned? I added couple of options where to place it in that review

@kayagokalp Addressed

Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kayagokalp kayagokalp enabled auto-merge (squash) January 10, 2024 18:33
@kayagokalp kayagokalp merged commit 5dda9a7 into FuelLabs:master Jan 11, 2024
29 checks passed
@Halimao Halimao deleted the fix/forc-build branch January 11, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged forc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forc panics if the Sway package folder contains dot (.)
3 participants