Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support recover key #5419

Merged
merged 15 commits into from
Jan 23, 2024
Merged

Add support recover key #5419

merged 15 commits into from
Jan 23, 2024

Conversation

crodas
Copy link
Contributor

@crodas crodas commented Dec 21, 2023 •
edited
Loading

Description

Fixes #5485

Add recover-public-key to forc-crypto

This function is ported from FuelLabs/forc-wallet#152

This PR depends on #5388

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@crodas crodas self-assigned this Dec 21, 2023
@crodas crodas mentioned this pull request Dec 21, 2023
Closed
@crodas
Copy link
Contributor Author

crodas commented Dec 21, 2023

@JoshuaBatty @sdankel how do we give credit to @quidproquoo for their original PR?

@crodas crodas force-pushed the add-support-recover-key branch from 32481b6 to ff5a69f Compare December 21, 2023 20:39
@crodas crodas force-pushed the add-support-recover-key branch from a27d5ef to 84bb5a3 Compare January 10, 2024 12:34
@crodas crodas marked this pull request as ready for review January 10, 2024 12:35
@crodas crodas requested a review from a team January 10, 2024 12:35
@kayagokalp kayagokalp added enhancement New feature or request forc labels Jan 10, 2024
@crodas crodas enabled auto-merge (squash) January 10, 2024 15:28
@crodas crodas force-pushed the add-support-recover-key branch from 09ff648 to 13b3d2f Compare January 16, 2024 04:55
@crodas crodas force-pushed the add-support-recover-key branch from f3592bd to 36db222 Compare January 17, 2024 17:42
@crodas crodas requested review from JoshuaBatty and a team January 17, 2024 19:24
@crodas crodas requested a review from sdankel January 18, 2024 18:56
@crodas crodas requested a review from a team January 19, 2024 14:17
crodas and others added 2 commits January 22, 2024 11:51
@JoshuaBatty JoshuaBatty requested a review from a team January 22, 2024 22:31
@crodas crodas merged commit a8d76e3 into master Jan 23, 2024
37 checks passed
@crodas crodas deleted the add-support-recover-key branch January 23, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@sdankel sdankel sdankel approved these changes

Assignees

@crodas crodas

Labels
enhancement New feature or request forc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add forc crypto sub command to extract public key from a message and its signature
4 participants
@crodas @JoshuaBatty @sdankel @kayagokalp