Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky LSP test: go_to_definition_for_paths #6029

Open
kayagokalp opened this issue May 17, 2024 · 2 comments
Open

Flaky LSP test: go_to_definition_for_paths #6029

kayagokalp opened this issue May 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@kayagokalp
Copy link
Member

Realized this #5980

  1. Succeeded locally
  2. https://github.com/FuelLabs/sway/actions/runs/9121461717/job/25080660551?pr=5980 -- first run failed
  3. https://github.com/FuelLabs/sway/actions/runs/9121461717/job/25081063304?pr=5980 -- second run ✅

cc @FuelLabs/tooling
@kayagokalp kayagokalp added bug Something isn't working language server LSP server testing General testing labels May 17, 2024
@kayagokalp kayagokalp mentioned this issue May 23, 2024
Merged
@sdankel
Copy link
Member

sdankel commented Aug 16, 2024

This PR failed when rerunning CI and didn't touch this part of the code at all https://github.com/FuelLabs/sway/actions/runs/10426298793/job/28878975861?pr=6422

@sdankel
Copy link
Member

sdankel commented Sep 9, 2024

Another example: https://github.com/FuelLabs/sway/actions/runs/10781130365/job/29898407068?pr=5539

@JoshuaBatty JoshuaBatty mentioned this issue Sep 10, 2024
Merged
8 tasks
JoshuaBatty added a commit that referenced this issue Sep 11, 2024
@JoshuaBatty
Use cargo-nextest with retries for flaky LSP test (#6521)
2f4fa65 
## Description
This PR introduces [`cargo-nextest`](https://nexte.st/) to improve our
test runs. We've configured 2 retries for the go_to_definition_for_paths
test, which has been intermittently failing. The LSP CI workflow has
been updated to use `cargo-nextest`.

Should mitigate #6029 until we get to the root cause why these tests are
flaky.

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
@JoshuaBatty JoshuaBatty added the Migrated label Jan 29, 2025 — with Linear
@JoshuaBatty JoshuaBatty removed testing General testing language server LSP server Migrated labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JoshuaBatty @kayagokalp @sdankel