Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forc-deploy cli tests should not coincide with local wallet instances while running cargo test locally #5484

Closed
kayagokalp opened this issue Jan 17, 2024 · 1 comment
Labels
forc-deploy Everything to do with forc-deploy testing General testing

Comments

@kayagokalp
Copy link
Member

TL;DR: We need to make sure wallet instantiation is done at some tmp folder and cleared after the test.

related to #5482. Since tests are trying to deploy a contract, forc-deploy tries to look for local wallet in the default path. This is problematic because if a sway repo contributor has a forc-wallet installed at that path, the tests are stopped and vault password is asked to them. This caused me to miss couple of issues in the test suite because I thought the tests were passing. Instead tests were hanging as they were asking for my local forc-wallet password. This problem do not occur in CI environment as the environment is fresh and do not have any wallet installed. So rather than trying to unlock existing wallet, forc-deploy creates a new one in the default path which is killed before next run.

@kayagokalp kayagokalp added testing General testing forc-deploy Everything to do with forc-deploy labels Jan 17, 2024
@kayagokalp
Copy link
Member Author

Closed in favor of #6283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forc-deploy Everything to do with forc-deploy testing General testing
Projects
None yet
Development

No branches or pull requests

1 participant