-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: made ResourceCache
consider resource owner
#3697
Merged
Torres-ssf
merged 134 commits into
master
from
st/chore/made-resource-cache-owner-specific
Mar 6, 2025
Merged
chore!: made ResourceCache
consider resource owner
#3697
Torres-ssf
merged 134 commits into
master
from
st/chore/made-resource-cache-owner-specific
Mar 6, 2025
+811
−420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esource-cache-owner-specific
Coverage Report:
Changed Files:
|
arboleya
approved these changes
Mar 5, 2025
danielbate
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResourceCache
Owner-Aware #3696Release notes
In this release, we:
ResourceCache
to conform with newcoinsToSpend
limitationsSummary
This PR addresses three things:
1 - Resources IDs are now cached, considering their owner.
2 - A check has been added to prevent
Provider.getResourcesToSpend
from being called with more cached resource IDs than themax_inputs
value.3 - All resource cache-related tests from
provider.test.ts
have been moved toresource-cache.test.ts
to reduce the number of test cases in the original file, which was already too large.Breaking Changes
Checklist