-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return correct operations from coin and message inputs #2782
fix: return correct operations from coin and message inputs #2782
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do a contract call with an account that only have message to fund the transaction (to do that you can receive from the bridge as funds bridged will be message in fuel side)
Would it be worth adding a fuel-gauge test around this use-case?
packages/account/src/providers/transaction-summary/input.test.ts
Outdated
Show resolved
Hide resolved
This PR is published in NPM with version 0.0.0-pr-2782-20240724204846 |
getInputFromAssetId
returns correct InputMessage
coinInput
and InputMessage
inputs
Thanks for the confirmation @Torres-ssf I was unaware that's how a spendable message could be seeded. I've added a corresponding test in 2a5abea I had to remove the zero |
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻
Coverage Report:
Changed Files:
|
Closes Empty operation being returned in txSummary #2763
Related to fix: use fuels pr-2479 to ensure correct operations are shown fuels-wallet#1419
Release notes
In this release, we:
getInputFromAssetId
so it returns the correctInputCoin
andInputMessage
Summary
At the moment
getContractCallOperations
is currently returning empty operations on wallets that only have anInputMessage
but noInputCoin
, this is becausegetInputFromAssetId
function was only returningmessageInputs
with the 32ZeroBytes hex, which of course excludes any input from a contract call that has a separateassetId
such as a predicate call.Notes
The best way to verify that this fix works is to use this branches build with the fuel-wallet and test it against the connectors. FuelLabs/fuels-wallet#1415 goes into greater detail on how to reproduce the scenarios.
Checklist
tests
to prove my changesdocs