feat: backport switch blob ID calculation from data offset to configurable offset #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set (#1593) <!-- List the issues this PR closes (if any) in a bullet list format, e.g.: - Closes #ABCD - Closes #EFGH --> # Release notes <!-- Use this only if this PR requires a mention in the Release Notes Summary. Valuable features and critical fixes are good examples. For everything else, please delete the whole section. --> In this release, we: ~~- Previously deployed blobs are no longer accessible due to changes in blob ID calculation. Redeployment is required.~~ # Summary Updates blob ID calculation to use the configurable offset instead of the data offset, aligning with the updated design for scripts and predicates. `has_configurable_section_offset` function checks bytes 4 and 7 to distinguish binary versions. If byte 4 is 0x74 (JMPF), it considers byte 7: 0x02 means legacy, 0x04 means new, and any other value results in an error. <!-- Please write a summary of your changes and why you made them. Not all PRs will be complex or substantial enough to require this section, so you can remove it if you think it's unnecessary. --> # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - [x] I **reviewed** the **entire PR** myself (preferably, on GH UI) - [x] I **described** all **Breaking Changes** (or there's none) --------- Co-authored-by: hal3e <git@hal3e.io> Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com> (cherry picked from commit 7509a9a)
Salka1988
requested review from
digorithm,
hal3e,
MujkicA and
segfault-magnet
as code owners
segfault-magnet
approved these changes
Mar 3, 2025
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick from 7509a9a
Checklist