-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use total_gas
and total_fee
from tx status
#1574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
total_gas
and total_fee
from tx statustotal_gas
and total_fee
from tx status
segfault-magnet
previously approved these changes
Feb 14, 2025
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
MujkicA
reviewed
Feb 23, 2025
MujkicA
approved these changes
Feb 24, 2025
segfault-magnet
approved these changes
Feb 24, 2025
digorithm
approved these changes
Feb 24, 2025
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1394
Release notes
In this PR we expose the tx status from succeeded translations in our higher level APIs. The user can use the (if available)
tx_status
andtx_id
from the following transaction APIsSummary
The
GasValidation
trait is removed. This trait was used to make sure that thescript_gas_limit
is set correctly. Thescript_gas_limit
is either:0
if there is no script code,so an additional check before sending the tx is redundant - By removing it we have one less dry run before sending the tx.
Breaking Changes
get_response_from
method fromCallHandlers
CallResponse
refactored and addedtx_status: Success
fieldget_response
acceptsTxStatus
instead ofVec<Receipts>
new
is removed formCallResponse
GasValidation
trait is removed from transaction buildersAccount
stransfer
method returnsResult<TxResponse>
Account
sforce_transfer_to_contract
method returnsResult<TxResponse>
Account
swithdraw_to_base_layer
method returnsResult<WithdrawToBaseResponse>
Executable<Loader>
'supload_blob
returnsResult<Option<TxResponse>>
deploy
anddeploy_if_not_exists
returnResult<DeployResponse>
andResponse<Option<DeployResponse>>
respectively-
TransactionCost
's fieldgas_used
renamed toscript_gas
Checklist