Create initial Number utility package #1
Conversation
caendesilva
changed the title
Convention for directories is with trailing `/` Co-authored-by: Greg Korba <wirone@gmail.com>
Co-authored-by: Greg Korba <wirone@gmail.com>
From #1 (comment) Examples can be improved: - assigning to variable is not needed and is redundant (like `$spelledNumber` vs `Number::spell()`) - instead of commenting the intent, which is clear by the class+method itself, there should be actual output
Not needed as we don't specify anything custom here See #1 (comment)
Not needed as we don't specify anything custom here
Requested in #1 (comment)
Uses complete descriptions to be proper sentences that describes the intent Resolves #1 (comment)
Co-authored-by: Greg Korba <wirone@gmail.com>
Since PHP is not SemVer, we should rather limit upper version to the newest available one, which can be tested. Co-Authored-By: Greg Korba <wirone@gmail.com>
caendesilva
force-pushed
the
create-number-utility
branch
from
2d8bd68 to
e379ec8
Compare
While the code should run fine on 8.0, the libraries we use for testing do not, and I don't think a work around is worth it since 8.0 is no longer supported and 8.1 is the minimum official PHP version.
|
@Wirone Think we could get this published to packagist? |
|
It wasn't published 🙈? I don't have rights to the org on Packagist, unfortunately. @dragoonis was coordinating this package, maybe he can help. |
Nope, realized today it still was not published 🙈🙈 Wasn't sure who to ping |
|
Whoever has Merge rights should merge this to this organisation as it's own repo. Who is going to do it? |
|
@Wirone ping the right people. |
It's already merged, but it needs to be added to Packagist by someone with access to |
Abstract
Hey everyone! Quick introduction here. I'm Caen, creator of the Number PR of Laravel. In this repo I'm porting that utility so it can be used in all PHP projects. This is my first Friends Of PHP Package, so I'm starting this discussion to ensure that everything matches the style and structure of your other packages.
Checklist
Composer package name
I based the package name on the PHP-CS-Fixer package. Is this okay?
Utility namespace
Is this an appropriate namespace?
Coding styles
Which coding style should we use? Code is currently formatted according to the PER standard: www.php-fig.org/per/coding-style
Documentation site
How do you want to handle documentation? My go-to for simple packages is to use GitHub Pages to create a static site from the README (or Markdown docs in the repo) using HydePHP. (For example hydephp.github.io/action and git.desilva.se/Speacher which both just need a short GitHub Actions workflow)