chore: enable phpstan (#39)

* chore: enable phpstan

* chore: bump js deps

* fix: set accessor public

.github/workflows/backend.yml

@@ -0,0 +1,12 @@
+name: FoF Passport PHP
+
+on: [workflow_dispatch, push, pull_request]
+
+jobs:
+  run:
+    uses: flarum/framework/.github/workflows/REUSABLE_backend.yml@main
+    with:
+      enable_backend_testing: false
+      enable_phpstan: true
+
+      backend_directory: .

.github/workflows/build.yml → .github/workflows/frontend.yml

@@ -1,4 +1,4 @@
-name: Javascript
+name: FoF Passport JS
 
 on: [workflow_dispatch, push, pull_request]
 
@@ -8,11 +8,12 @@ jobs:
     with:
       enable_bundlewatch: false
       enable_prettier: true
-      enable_typescript: false
+      enable_typescript: true
 
       frontend_directory: ./js
       backend_directory: .
       js_package_manager: npm
       main_git_branch: master
+
     secrets:
       bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}

composer.json

@@ -53,11 +53,26 @@
         },
         "flagrow": {
             "discuss": "https://discuss.flarum.org/d/5203"
+        },
+        "flarum-cli": {
+            "modules": {
+                "githubActions": true
+            }
         }
     },
     "autoload": {
         "psr-4": {
             "FoF\\Passport\\": "src/"
         }
+    },
+    "require-dev": {
+        "flarum/phpstan": "*"
+    },
+    "scripts": {
+        "analyse:phpstan": "phpstan analyse",
+        "clear-cache:phpstan": "phpstan clear-result-cache"
+    },
+    "scripts-descriptions": {
+        "analyse:phpstan": "Run static analysis"
     }
 }

js/package.json

@@ -6,11 +6,11 @@
       "@flarum/prettier-config": "^1.0.0",
       "flarum-tsconfig": "^1.0.2",
       "flarum-webpack-config": "^2.0.0",
-      "webpack": "^5.76.1",
-      "webpack-cli": "^5.0.1"
+      "webpack": "^5.89.0",
+      "webpack-cli": "^5.1.4"
     },
     "devDependencies": {
-      "prettier": "^2.8.4"
+      "prettier": "^3.0.3"
     },
     "scripts": {
       "dev": "webpack --mode development --watch",

phpstan.neon

@@ -0,0 +1,13 @@
+includes:
+  - vendor/flarum/phpstan/extension.neon
+
+parameters:
+  # The level will be increased in Flarum 2.0
+  level: 5
+  paths:
+    - extend.php
+    - src
+  excludePaths:
+    - *.blade.php
+  checkMissingIterableValueType: false
+  databaseMigrationsPath: ['migrations']

src/ResourceOwner.php

@@ -23,7 +23,7 @@ class ResourceOwner implements ResourceOwnerInterface
      */
     private $response;
 
-    private static $fields = [];
+    public static $fields = [];
 
     public function __construct(array $response = [])
     {