Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[license-dialog] Fixed the retrieving of the selected license's ID fr… #730

Merged

Conversation

fajardoleo
Copy link
Contributor

…om the license update dialog.

@fajardoleo fajardoleo requested a review from swashata July 31, 2024 17:26
@fajardoleo fajardoleo self-assigned this Jul 31, 2024
@fajardoleo fajardoleo force-pushed the feature/license-dialog-selected-license-fix branch from 87cd8ae to f454c05 Compare October 23, 2024 13:35
@DanieleAlessandra DanieleAlessandra requested review from DanieleAlessandra and removed request for swashata November 14, 2024 16:17
Copy link
Collaborator

@DanieleAlessandra DanieleAlessandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed solution solves the issue, please note that both licenseID and licenseKey must be string for this script to work.

@fajardoleo fajardoleo force-pushed the feature/license-dialog-selected-license-fix branch 2 times, most recently from 52d5664 to b6c70ac Compare November 18, 2024 00:35
@fajardoleo fajardoleo force-pushed the feature/license-dialog-selected-license-fix branch from b6c70ac to 84333b6 Compare November 18, 2024 00:44
@DanieleAlessandra DanieleAlessandra merged commit a137bf2 into develop Nov 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants